[SDK] Fix: Improve PayEmbed error message parsing #6732
Conversation
🦋 Changeset detectedLatest commit: 5d344ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
gregfromstl
force-pushed
the
greg/pay-error-messages
branch
from
3d23dd4 to
5d344ec
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6732 +/- ##
==========================================
- Coverage 54.82% 54.79% -0.03%
==========================================
Files 895 895
Lines 56360 56376 +16
Branches 3848 3849 +1
==========================================
- Hits 30899 30894 -5
- Misses 25366 25387 +21
Partials 95 95
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on improving error messages related to user wallet interactions in the
thirdwebpackage. It expands the conditions for handling rejection errors to include cases where the user closed the modal or denied the request.Detailed summary
SendFunds.tsxto include "user closed modal" and "user denied".TransferConfirmationScreen.tsxfor approval errors.ConfirmationScreen.tsxfor both approval and swap errors.